Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Unified Diff: media/muxers/webm_muxer_unittest.cc

Issue 2691373005: Support alpha channel recording for VPX in MediaRecorder (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/muxers/webm_muxer.cc ('K') | « media/muxers/webm_muxer_fuzzertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/muxers/webm_muxer_unittest.cc
diff --git a/media/muxers/webm_muxer_unittest.cc b/media/muxers/webm_muxer_unittest.cc
index 8dcceb88b2aaf29863be6da7fc8de7f9891ad473..3b34b3e125aa01b4f5f50d8c5881bbee774033a3 100644
--- a/media/muxers/webm_muxer_unittest.cc
+++ b/media/muxers/webm_muxer_unittest.cc
@@ -111,8 +111,8 @@ TEST_P(WebmMuxerTest, OnEncodedVideoTwoFrames) {
WithArgs<0>(Invoke(this, &WebmMuxerTest::SaveEncodedDataLen)));
EXPECT_TRUE(webm_muxer_.OnEncodedVideo(
WebmMuxer::VideoParameters(video_frame),
- base::WrapUnique(new std::string(encoded_data)), base::TimeTicks::Now(),
- false /* keyframe */));
+ base::WrapUnique(new std::string(encoded_data)), nullptr,
+ base::TimeTicks::Now(), false /* keyframe */));
// First time around WriteCallback() is pinged a number of times to write the
// Matroska header, but at the end it dumps |encoded_data|.
@@ -127,7 +127,7 @@ TEST_P(WebmMuxerTest, OnEncodedVideoTwoFrames) {
.WillRepeatedly(
WithArgs<0>(Invoke(this, &WebmMuxerTest::SaveEncodedDataLen)));
EXPECT_TRUE(webm_muxer_.OnEncodedVideo(
- video_frame, base::WrapUnique(new std::string(encoded_data)),
+ video_frame, base::WrapUnique(new std::string(encoded_data)), nullptr,
base::TimeTicks::Now(), false /* keyframe */));
// The second time around the callbacks should include a SimpleBlock header,
@@ -141,10 +141,10 @@ TEST_P(WebmMuxerTest, OnEncodedVideoTwoFrames) {
// Force an error in libwebm and expect OnEncodedVideo to fail.
webm_muxer_.ForceOneLibWebmErrorForTesting();
- EXPECT_FALSE(
- webm_muxer_.OnEncodedVideo(WebmMuxer::VideoParameters(video_frame),
- base::MakeUnique<std::string>(encoded_data),
- base::TimeTicks::Now(), true /* keyframe */));
+ EXPECT_FALSE(webm_muxer_.OnEncodedVideo(
+ WebmMuxer::VideoParameters(video_frame),
+ base::MakeUnique<std::string>(encoded_data), nullptr,
+ base::TimeTicks::Now(), true /* keyframe */));
}
TEST_P(WebmMuxerTest, OnEncodedAudioTwoFrames) {
@@ -215,14 +215,14 @@ TEST_P(WebmMuxerTest, VideoIsStoredWhileWaitingForAudio) {
const std::string encoded_video("thisisanencodedvideopacket");
EXPECT_TRUE(webm_muxer_.OnEncodedVideo(
WebmMuxer::VideoParameters(video_frame),
- base::WrapUnique(new std::string(encoded_video)), base::TimeTicks::Now(),
- true /* keyframe */));
+ base::WrapUnique(new std::string(encoded_video)), nullptr,
+ base::TimeTicks::Now(), true /* keyframe */));
// A few encoded non key frames.
const int kNumNonKeyFrames = 2;
for (int i = 0; i < kNumNonKeyFrames; ++i) {
EXPECT_TRUE(webm_muxer_.OnEncodedVideo(
WebmMuxer::VideoParameters(video_frame),
- base::WrapUnique(new std::string(encoded_video)),
+ base::WrapUnique(new std::string(encoded_video)), nullptr,
base::TimeTicks::Now(), false /* keyframe */));
}
« media/muxers/webm_muxer.cc ('K') | « media/muxers/webm_muxer_fuzzertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698