[Android History] Even more polish

chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.history;
 
 import android.app.Activity;
 import android.app.ActivityManager;
 import android.content.ComponentName;
 import android.content.Context;
@@ skipping 21 matching lines @@
 import org.chromium.base.metrics.RecordUserAction;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.IntentHandler;
 import org.chromium.chrome.browser.NativePage;
 import org.chromium.chrome.browser.document.ChromeLauncherActivity;
 import org.chromium.chrome.browser.favicon.LargeIconBridge;
 import org.chromium.chrome.browser.preferences.PreferencesLauncher;
 import org.chromium.chrome.browser.profiles.Profile;
 import org.chromium.chrome.browser.signin.SigninManager;
 import org.chromium.chrome.browser.signin.SigninManager.SignInStateObserver;
+import org.chromium.chrome.browser.snackbar.Snackbar;
+import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarController;
+import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarManageable;
 import org.chromium.chrome.browser.util.IntentUtils;
 import org.chromium.chrome.browser.widget.FadingShadowView;
 import org.chromium.chrome.browser.widget.selection.SelectableListLayout;
 import org.chromium.chrome.browser.widget.selection.SelectableListToolbar.SearchDelegate;
 import org.chromium.chrome.browser.widget.selection.SelectionDelegate;
 import org.chromium.chrome.browser.widget.selection.SelectionDelegate.SelectionObserver;
 import org.chromium.ui.base.Clipboard;
 import org.chromium.ui.base.DeviceFormFactor;
 
 import java.util.List;
 
 /**
  * Displays and manages the UI for browsing history.
  */
 public class HistoryManager implements OnMenuItemClickListener, SignInStateObserver,
-        SelectionObserver<HistoryItem>, SearchDelegate {
+                                       SelectionObserver<HistoryItem>, SearchDelegate,
+                                       SnackbarController {
     private static final int FAVICON_MAX_CACHE_SIZE_BYTES = 10 * 1024 * 1024; // 10MB
     private static final int MEGABYTES_TO_BYTES =  1024 * 1024;
     private static final String METRICS_PREFIX = "Android.HistoryPage.";
 
     private static HistoryProvider sProviderForTests;
 
     private final int mListItemLateralShadowSizePx;
     private final int mDefaultLateralListItemMarginPx;
 
     private final Activity mActivity;
@@ skipping 43 matching lines @@
         mToolbarShadow = (FadingShadowView) mSelectableListLayout.findViewById(R.id.shadow);
         mToolbarShadow.setVisibility(View.GONE);
 
         // 4. Configure values for HorizontalDisplayStyle.WIDE and HorizontalDisplayStyle.REGULAR.
         // The list item shadow is part of the drawable nine-patch used as the list item background.
         // Use the dimensions of the shadow (from the drawable's padding) to calculate the margins
         // to use in the regular and wide display styles.
         Rect listItemShadow = new Rect();
         ApiCompatibilityUtils.getDrawable(
                 mActivity.getResources(), R.drawable.card_middle).getPadding(listItemShadow);
-        int cardCornerRadius = mActivity.getResources().getDimensionPixelSize(
-                R.dimen.card_corner_radius);
+        int cardCornerRadius =
+                mActivity.getResources().getDimensionPixelSize(R.dimen.list_item_corner_radius);
 
         assert listItemShadow.left == listItemShadow.right;
         // The list item shadow size is used in HorizontalDisplayStyle.WIDE to visually align other
         // elements with the edge of the list items.
         mListItemLateralShadowSizePx = listItemShadow.left;
         // A negative margin is used in HorizontalDisplayStyle.REGULAR to hide the lateral shadow.
         mDefaultLateralListItemMarginPx = -(listItemShadow.left + cardCornerRadius);
 
         mSelectableListLayout.setHasWideDisplayStyle(mListItemLateralShadowSizePx);
 
@@ skipping 44 matching lines @@
 
     /**
      * @return Whether the history manager UI is displayed in a native page.
      */
     public boolean isDisplayedInNativePage() {
         return mIsDisplayedInNativePage;
     }
 
     @Override
     public boolean onMenuItemClick(MenuItem item) {
+        mToolbar.hideOverflowMenu();
+
         if (item.getItemId() == R.id.close_menu_id && !isDisplayedInNativePage()) {
             mActivity.finish();
             return true;
         } else if (item.getItemId() == R.id.selection_mode_open_in_new_tab) {
             openItemsInNewTabs(mSelectionDelegate.getSelectedItems(), false);
             mSelectionDelegate.clearSelection();
             return true;
         } else if (item.getItemId() == R.id.selection_mode_copy_link) {
             recordUserActionWithOptionalSearch("CopyLink");
             Clipboard clipboard = new Clipboard(mActivity);
             clipboard.setText(mSelectionDelegate.getSelectedItems().get(0).getUrl());
+            mSelectionDelegate.clearSelection();
+            Snackbar snackbar = Snackbar.make(mActivity.getString(R.string.copied), this,
+                    Snackbar.TYPE_NOTIFICATION, Snackbar.UMA_HISTORY_LINK_COPIED);
+            ((SnackbarManageable) mActivity).getSnackbarManager().showSnackbar(snackbar);

[gone, 2017/02/16 19:29:16]

Any reason we're using a snackbar instead of a toast?

[Theresa, 2017/02/16 19:59:10]

I asked UX if we could use a toast and they said no. They were trying to achieve
consistency with the "Bookmarked" snackbar that shows up when you bookmark
something.

             return true;
         } else if (item.getItemId() == R.id.selection_mode_open_in_incognito) {
             openItemsInNewTabs(mSelectionDelegate.getSelectedItems(), true);
             mSelectionDelegate.clearSelection();
             return true;
         } else if (item.getItemId() == R.id.selection_mode_delete_menu_id) {
             recordSelectionCountHistorgram("Remove");
             recordUserActionWithOptionalSearch("RemoveSelected");
 
             for (HistoryItem historyItem : mSelectionDelegate.getSelectedItems()) {
@@ skipping 224 matching lines @@
         mToolbar.onSignInStateChange();
         mHistoryAdapter.onSignInStateChange();
     }
 
     @Override
     public void onSelectionStateChange(List<HistoryItem> selectedItems) {
         mHistoryAdapter.onSelectionStateChange(mSelectionDelegate.isSelectionEnabled());
         setToolbarShadowVisibility();
     }
 
+    @Override
+    public void onAction(Object actionData) {
+        // Handler for the link copied snackbar. Do nothing.
+    }
+
+    @Override
+    public void onDismissNoAction(Object actionData) {
+        // Handler for the link copied snackbar. Do nothing.
+    }
+
     private void setToolbarShadowVisibility() {
         boolean showShadow = mRecyclerView.computeVerticalScrollOffset() != 0
                 || mIsSearching || mSelectionDelegate.isSelectionEnabled();
         mToolbarShadow.setVisibility(showShadow ? View.VISIBLE : View.GONE);
     }
 }