Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Side by Side Diff: chrome/android/java/res/layout/history_item_view.xml

Issue 2691373004: [Android History] Even more polish (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2016 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <org.chromium.chrome.browser.history.HistoryItemView 6 <org.chromium.chrome.browser.history.HistoryItemView
7 xmlns:android="http://schemas.android.com/apk/res/android" 7 xmlns:android="http://schemas.android.com/apk/res/android"
8 xmlns:chrome="http://schemas.android.com/apk/res-auto" 8 xmlns:chrome="http://schemas.android.com/apk/res-auto"
9 android:layout_width="match_parent" 9 android:layout_width="match_parent"
10 android:layout_height="wrap_content" > 10 android:layout_height="wrap_content" >
11 11
12 <!-- TODO(twellington): remove start/end padding when new assets with
13 correct built in padding are available. -->
12 <LinearLayout 14 <LinearLayout
13 android:id="@+id/content" 15 android:id="@+id/content"
14 android:layout_width="match_parent" 16 android:layout_width="match_parent"
15 android:layout_height="wrap_content" 17 android:layout_height="wrap_content"
16 android:paddingTop="16dp" 18 android:paddingTop="16dp"
17 android:paddingBottom="16dp" 19 android:paddingBottom="16dp"
20 android:paddingStart="1dp"
Theresa 2017/02/15 21:41:04 This should be moved to HistoryItemView above sinc
Theresa 2017/02/15 23:16:15 Done.
21 android:paddingEnd="1dp"
18 android:orientation="horizontal" > 22 android:orientation="horizontal" >
19 23
20 <ImageView 24 <ImageView
21 android:id="@+id/icon_view" 25 android:id="@+id/icon_view"
22 style="@style/HistoryStartIcon" 26 style="@style/HistoryStartIcon"
23 android:contentDescription="@null" 27 android:contentDescription="@null"
24 android:src="@drawable/default_favicon" /> 28 android:src="@drawable/default_favicon" />
25 29
26 <LinearLayout 30 <LinearLayout
27 android:layout_width="0dp" 31 android:layout_width="0dp"
(...skipping 23 matching lines...) Expand all
51 55
52 <org.chromium.chrome.browser.widget.TintedImageButton 56 <org.chromium.chrome.browser.widget.TintedImageButton
53 android:id="@+id/remove" 57 android:id="@+id/remove"
54 style="@style/HistoryEndIcon" 58 style="@style/HistoryEndIcon"
55 android:contentDescription="@string/remove" 59 android:contentDescription="@string/remove"
56 android:src="@drawable/btn_trash" 60 android:src="@drawable/btn_trash"
57 chrome:tint="@color/dark_mode_tint" /> 61 chrome:tint="@color/dark_mode_tint" />
58 </LinearLayout> 62 </LinearLayout>
59 63
60 </org.chromium.chrome.browser.history.HistoryItemView> 64 </org.chromium.chrome.browser.history.HistoryItemView>
OLDNEW
« no previous file with comments | « chrome/android/java/res/layout/history_header.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698