Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mash/quick_launch/quick_launch.cc

Issue 2691363004: chromeos: Makes ~QuickLaunch delete widgets (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mash/quick_launch/quick_launch.cc
diff --git a/mash/quick_launch/quick_launch.cc b/mash/quick_launch/quick_launch.cc
index 246e933c5ac5e0322f361d670e7e057d6793c0fb..691210eb13f23fd374931b1b71f12272adb8f7cb 100644
--- a/mash/quick_launch/quick_launch.cc
+++ b/mash/quick_launch/quick_launch.cc
@@ -154,7 +154,10 @@ class QuickLaunchUI : public views::WidgetDelegateView,
QuickLaunch::QuickLaunch() {
registry_.AddInterface<::mash::mojom::Launchable>(this);
}
Elliot Glaysher 2017/02/15 20:08:30 nit: newline between ctor and dtor?
sky 2017/02/15 20:10:01 Done.
-QuickLaunch::~QuickLaunch() {}
+QuickLaunch::~QuickLaunch() {
+ while (!windows_.empty())
+ windows_.front()->CloseNow();
+}
void QuickLaunch::RemoveWindow(views::Widget* window) {
auto it = std::find(windows_.begin(), windows_.end(), window);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698