Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1415)

Unified Diff: ui/compositor/test/in_process_context_factory.cc

Issue 2691363002: Centralize FrameSinkId allocation in one place (Closed)
Patch Set: explicit Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/compositor/test/in_process_context_factory.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/compositor/test/in_process_context_factory.cc
diff --git a/ui/compositor/test/in_process_context_factory.cc b/ui/compositor/test/in_process_context_factory.cc
index 0a5be65e9fa2348b8cd73284239acb861ecfc957..4f0faf994e8fa85c3272106d818438d71fbd44ac 100644
--- a/ui/compositor/test/in_process_context_factory.cc
+++ b/ui/compositor/test/in_process_context_factory.cc
@@ -38,6 +38,9 @@
namespace ui {
namespace {
+// The client_id used here should not conflict with the client_id generated
+// from RenderWidgetHostImpl.
+constexpr uint32_t kDefaultClientId = 0u;
class FakeReflector : public Reflector {
public:
@@ -129,7 +132,7 @@ struct InProcessContextFactory::PerCompositorData {
InProcessContextFactory::InProcessContextFactory(
bool context_factory_for_test,
cc::SurfaceManager* surface_manager)
- : next_surface_sink_id_(1u),
+ : frame_sink_id_allocator_(kDefaultClientId),
use_test_surface_(true),
context_factory_for_test_(context_factory_for_test),
surface_manager_(surface_manager) {
@@ -285,12 +288,7 @@ cc::TaskGraphRunner* InProcessContextFactory::GetTaskGraphRunner() {
}
cc::FrameSinkId InProcessContextFactory::AllocateFrameSinkId() {
- // The FrameSinkId generated here must be unique with
- // RenderWidgetHostViewAura's
- // and RenderWidgetHostViewMac's FrameSinkId allocation.
- // TODO(crbug.com/685777): Centralize allocation in one place for easier
- // maintenance.
- return cc::FrameSinkId(0, next_surface_sink_id_++);
+ return frame_sink_id_allocator_.NextFrameSinkId();
}
cc::SurfaceManager* InProcessContextFactory::GetSurfaceManager() {
« no previous file with comments | « ui/compositor/test/in_process_context_factory.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698