Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1558)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 2691363002: Centralize FrameSinkId allocation in one place (Closed)
Patch Set: explicit Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
index f2c270f4e98538aa89fa4d6c538509d511e509ab..3609b89c2f7b028a60ad47b47d1f8bc73292999c 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -470,20 +470,8 @@ RenderWidgetHostViewMac::RenderWidgetHostViewMac(RenderWidgetHost* widget,
[cocoa_view_ setLayer:background_layer_];
[cocoa_view_ setWantsLayer:YES];
- // GuestViews have two RenderWidgetHostViews and so we need to make sure
- // we don't have FrameSinkId collisions.
- // The FrameSinkId generated here must be unique with FrameSinkId allocated
- // in ContextFactoryPrivate.
- // TODO(crbug.com/685777): Centralize allocation in one place for easier
- // maintenance.
- ImageTransportFactory* factory = ImageTransportFactory::GetInstance();
cc::FrameSinkId frame_sink_id =
- is_guest_view_hack_
- ? factory->GetContextFactoryPrivate()->AllocateFrameSinkId()
- : cc::FrameSinkId(base::checked_cast<uint32_t>(
- render_widget_host_->GetProcess()->GetID()),
- base::checked_cast<uint32_t>(
- render_widget_host_->GetRoutingID()));
+ render_widget_host_->AllocateFrameSinkId(is_guest_view_hack_);
browser_compositor_.reset(
new BrowserCompositorMac(this, this, render_widget_host_->is_hidden(),
[cocoa_view_ window], frame_sink_id));
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | ui/compositor/test/in_process_context_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698