content/browser/renderer_host/context_provider_factory_impl_android.h - Issue 2691363002: Centralize FrameSinkId allocation in one place

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/context_provider_factory_impl_android.h

Issue 2691363002: Centralize FrameSinkId allocation in one place (Closed)

Patch Set: fix nits Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/surfaces/frame_sink_id_allocator.h ('K') | « content/browser/compositor/gpu_process_transport_factory.cc ('k') | content/browser/renderer_host/context_provider_factory_impl_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/context_provider_factory_impl_android.h

diff --git a/content/browser/renderer_host/context_provider_factory_impl_android.h b/content/browser/renderer_host/context_provider_factory_impl_android.h

index 79a529b91e204046a2263ce427d332cc5832ac83..751cd42019c5c8e0e937fc28b0af09ebeae3a18c 100644

--- a/content/browser/renderer_host/context_provider_factory_impl_android.h

+++ b/content/browser/renderer_host/context_provider_factory_impl_android.h

@@ -10,6 +10,7 @@

#include "base/macros.h"

#include "base/memory/weak_ptr.h"

#include "base/timer/timer.h"

+#include "cc/surfaces/frame_sink_id_allocator.h"

#include "content/common/content_export.h"

#include "gpu/command_buffer/client/shared_memory_limits.h"

#include "gpu/command_buffer/common/gles2_cmd_utils.h"

@@ -104,7 +105,7 @@ class CONTENT_EXPORT ContextProviderFactoryImpl

base::OneShotTimer establish_gpu_channel_timeout_;

std::unique_ptr<cc::SurfaceManager> surface_manager_;

- uint32_t next_sink_id_;

+ cc::FrameSinkIdAllocator frame_sink_id_allocator_;

base::WeakPtrFactory<ContextProviderFactoryImpl> weak_factory_;