cc/surfaces/frame_sink_id_allocator.h - Issue 2691363002: Centralize FrameSinkId allocation in one place

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/surfaces/frame_sink_id_allocator.h

Issue 2691363002: Centralize FrameSinkId allocation in one place (Closed)

Patch Set: android Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« android_webview/browser/surfaces_instance.cc ('K') | « cc/surfaces/BUILD.gn ('k') | content/browser/compositor/gpu_process_transport_factory.h » ('j') | content/browser/compositor/gpu_process_transport_factory.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CC_SURFACES_FRAME_SINK_ID_ALLOCATOR_H_

	6 #define CC_SURFACES_FRAME_SINK_ID_ALLOCATOR_H_

	7

	8 #include "cc/surfaces/frame_sink_id.h"

	9

	10 namespace cc {

	11

	12 class FrameSinkIdAllocator {
	Fady Samuel 2017/02/15 20:20:59 Class level comment explaining the purpose of this Class level comment explaining the purpose of this class. xlai (Olivia) 2017/02/15 22:38:36 Done. Show quoted text On 2017/02/15 20:20:59, Fady Samuel wrote: > Class level comment explaining the purpose of this class. Done.
	13 public:

	14 FrameSinkId NextFrameSinkId() { return FrameSinkId(0, next_sink_id_++); }
	boliu 2017/02/15 19:59:20 should have a comment here why the first part must should have a comment here why the first part must be 0 danakj 2017/02/15 20:18:10 It seems very action-at-a-distance to decide 0 her Show quoted text On 2017/02/15 19:59:20, boliu wrote: > should have a comment here why the first part must be 0 It seems very action-at-a-distance to decide 0 here in order to not collide with RenderWidgetHostImpl (if I am understanding the reasoning correctly?) It would be more straightforward I think to take the 0 in the constructor, or as a parameter to this method, and have the callers pass 0 with a comment that 0 will be different than RenderWidgetHostImpl. Also then RWHI could use this class? wdyt? Fady Samuel 2017/02/15 20:20:59 Actually I'd prefer that the client_id be a param Show quoted text On 2017/02/15 19:59:20, boliu wrote: > should have a comment here why the first part must be 0 Actually I'd prefer that the client_id be a param into the constructor. xlai (Olivia) 2017/02/15 22:38:36 Done. Show quoted text On 2017/02/15 20:20:59, Fady Samuel wrote: > On 2017/02/15 19:59:20, boliu wrote: > > should have a comment here why the first part must be 0 > > Actually I'd prefer that the client_id be a param into the constructor. Done.
	15

	16 private:

	17 uint32_t next_sink_id_ = 1u;
	boliu 2017/02/15 19:59:20 DISALLOW_COPY_AND_ASSIGN? DISALLOW_COPY_AND_ASSIGN? xlai (Olivia) 2017/02/15 22:38:36 Done. Show quoted text On 2017/02/15 19:59:20, boliu wrote: > DISALLOW_COPY_AND_ASSIGN? Done.
	18 };

	19

	20 } // namespace cc

	21

	22 #endif // CC_SURFACES_FRAME_SINK_ID_ALLOCATOR_H_

OLD	NEW