Centralize FrameSinkId allocation in one place

content/browser/renderer_host/context_provider_factory_impl_android.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/context_provider_factory_impl_android.h"
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/singleton.h"
 #include "cc/output/context_provider.h"
 #include "cc/output/vulkan_in_process_context_provider.h"
 #include "cc/surfaces/surface_manager.h"
 #include "content/browser/gpu/browser_gpu_memory_buffer_manager.h"
 #include "content/browser/gpu/compositor_util.h"
 #include "content/common/host_shared_bitmap_manager.h"
 #include "content/public/common/content_switches.h"
 #include "gpu/command_buffer/client/gles2_interface.h"
 #include "gpu/command_buffer/client/gpu_memory_buffer_manager.h"
 #include "gpu/ipc/client/gpu_channel_host.h"
 #include "services/ui/public/cpp/gpu/context_provider_command_buffer.h"
 
 namespace content {
 
 namespace {
 
+// The client_id used here should not conflict with the client_id generated
+// from RenderWidgetHostImpl.
+constexpr uint32_t kDefaultClientId = 0u;
+
 ui::command_buffer_metrics::ContextType ToCommandBufferContextType(
     ui::ContextProviderFactory::ContextType context_type) {
   switch (context_type) {
     case ui::ContextProviderFactory::ContextType::
         BLIMP_RENDER_COMPOSITOR_CONTEXT:
       return ui::command_buffer_metrics::BLIMP_RENDER_COMPOSITOR_CONTEXT;
     case ui::ContextProviderFactory::ContextType::BLIMP_RENDER_WORKER_CONTEXT:
       return ui::command_buffer_metrics::BLIMP_RENDER_WORKER_CONTEXT;
   }
   NOTREACHED();
@@ skipping 20 matching lines @@
 // static
 ContextProviderFactoryImpl* ContextProviderFactoryImpl::GetInstance() {
   return instance;
 }
 
 ContextProviderFactoryImpl::ContextProviderFactoryImpl(
     gpu::GpuChannelEstablishFactory* gpu_channel_factory)
     : gpu_channel_factory_(gpu_channel_factory),
       in_handle_pending_requests_(false),
       in_shutdown_(false),
-      next_sink_id_(1u),
+      frame_sink_id_allocator_(kDefaultClientId),
       weak_factory_(this) {
   DCHECK(gpu_channel_factory_);
 }
 
 ContextProviderFactoryImpl::~ContextProviderFactoryImpl() {
   in_shutdown_ = true;
   if (!gpu_channel_requests_.empty())
     HandlePendingRequests(nullptr,
                           GpuChannelHostResult::FAILURE_FACTORY_SHUTDOWN);
 }
@@ skipping 49 matching lines @@
 }
 
 cc::SurfaceManager* ContextProviderFactoryImpl::GetSurfaceManager() {
   if (!surface_manager_)
     surface_manager_ = base::WrapUnique(new cc::SurfaceManager);
 
   return surface_manager_.get();
 }
 
 cc::FrameSinkId ContextProviderFactoryImpl::AllocateFrameSinkId() {
-  // The FrameSinkId generated here must be unique with
-  // RenderWidgetHostViewAndroid's
-  // FrameSinkId allocation.
-  // TODO(crbug.com/685777): Centralize allocation in one place for easier
-  // maintenance.
-  return cc::FrameSinkId(0 /* client_id */, next_sink_id_++);
+  return frame_sink_id_allocator_.NextFrameSinkId();
 }
 
 gpu::GpuMemoryBufferManager*
 ContextProviderFactoryImpl::GetGpuMemoryBufferManager() {
   return BrowserGpuMemoryBufferManager::current();
 }
 
 scoped_refptr<cc::ContextProvider>
 ContextProviderFactoryImpl::CreateContextProviderInternal(
     ui::command_buffer_metrics::ContextType context_type,
@@ skipping 83 matching lines @@
         nullptr,
         GpuChannelHostResult::FAILURE_GPU_PROCESS_INITIALIZATION_FAILED);
   }
 }
 
 void ContextProviderFactoryImpl::OnGpuChannelTimeout() {
   LOG(FATAL) << "Timed out waiting for GPU channel.";
 }
 
 }  // namespace content