build/android/gradle/manifest.jinja - Issue 2691353005: Generate custom manifests when letting gradle process resources.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/gradle/manifest.jinja

Issue 2691353005: Generate custom manifests when letting gradle process resources. (Closed)

Patch Set: Changes according to Peter's comments. #1 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 {# Copyright 2017 The Chromium Authors. All rights reserved. #}

	2 {# Use of this source code is governed by a BSD-style license that can be #}

	3 {# found in the LICENSE file. #}

	4 <?xml version="1.0" encoding="utf-8"?>

	5 <manifest xmlns:android="http://schemas.android.com/apk/res/android"

	6 package="{{ package }}">

	7

	8 {# This should be kept in sync with build/android/AndroidManifest.xml. #}

	9 <uses-sdk android:minSdkVersion="16" android:targetSdkVersion="24" />
	agrieve 2017/02/16 15:28:01 nit: make the targetSdkVersion be {{compile_sdk_ve nit: make the targetSdkVersion be {{compile_sdk_version}} sakal-chromium 2017/02/16 15:47:37 Done. Show quoted text On 2017/02/16 15:28:01, agrieve wrote: > nit: make the targetSdkVersion be {{compile_sdk_version}} Done.
	10

	11 </manifest>

OLD	NEW