Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8655)

Unified Diff: chrome/browser/ui/views/passwords/credentials_selection_view.h

Issue 2691323002: Fixed memory leak in Password Manager UI. (Closed)
Patch Set: Addressing reviewer's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/credentials_selection_view.h
diff --git a/chrome/browser/ui/views/passwords/credentials_selection_view.h b/chrome/browser/ui/views/passwords/credentials_selection_view.h
index 07b6f26aff73a99b7ef69196cae71f384f0f6c05..b71e2985b5195a28d21539d969d38c3f2da6d7fc 100644
--- a/chrome/browser/ui/views/passwords/credentials_selection_view.h
+++ b/chrome/browser/ui/views/passwords/credentials_selection_view.h
@@ -4,6 +4,7 @@
#ifndef CHROME_BROWSER_UI_VIEWS_PASSWORDS_CREDENTIALS_SELECTION_VIEW_H_
#define CHROME_BROWSER_UI_VIEWS_PASSWORDS_CREDENTIALS_SELECTION_VIEW_H_
+#include <memory>
#include <vector>
#include "base/macros.h"
@@ -14,6 +15,10 @@ namespace views {
class Combobox;
}
+namespace ui {
+class SimpleComboboxModel;
+}
+
class ManagePasswordsBubbleModel;
// A view where the user can select a credential.
@@ -27,12 +32,12 @@ class CredentialsSelectionView : public views::View {
const autofill::PasswordForm* GetSelectedCredentials();
private:
- views::Combobox* GenerateUsernameCombobox(
- const base::string16& best_matched_username);
+ void GenerateUsernameCombobox(const base::string16& best_matched_username);
void ReportUserActionOnce(bool was_update_rejected, int selected_index);
const std::vector<autofill::PasswordForm>* password_forms_;
- views::Combobox* combobox_;
+ std::unique_ptr<views::Combobox> combobox_;
+ std::unique_ptr<ui::SimpleComboboxModel> combobox_model_;
int default_index_;
bool is_default_best_match_;
bool is_default_preferred_;

Powered by Google App Engine
This is Rietveld 408576698