start/stop method for AudioBufferSourceNodes and OscillatorNodes can take no args.

Source/modules/webaudio/AudioBufferSourceNode.cpp

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 354 matching lines @@
     m_buffer = buffer;
 
     return true;
 }
 
 unsigned AudioBufferSourceNode::numberOfChannels()
 {
     return output(0)->numberOfChannels();
 }
 
-void AudioBufferSourceNode::startGrain(double when, double grainOffset)
+void AudioBufferSourceNode::start(double when)
 {
-    // Duration of 0 has special value, meaning calculate based on the entire buffer's duration.
-    startGrain(when, grainOffset, 0);
+    AudioScheduledSourceNode::start(when);

[Ken Russell (switch to Gerrit), 2013/10/14 22:54:05]

Are you sure it's correct to delegate to AudioScheduledSourceNode::start here?
The previous implementation used to delegate
AudioBufferSourceNode::startGrain(double, double, double) (which is now
::start(...)), and it looks like it does a *lot* more work for
AudioBufferSourceNodes than AudioScheduledSourceNode::start does.

I assume that there are already existing WebAudio layout tests that cover this
functionality and which work after this change?

[Raymond Toy (Google), 2013/10/28 17:34:57]

The diff is confusing.  A plain start(when) is the simple start method that
doesn't deal with the issues with startGrain.  We didn't really replace
startGrain with start.  startGrain with 2 args is converted to startGrain (now
called start) with 3 args by using a default value for the third arg.
 
Yes, there are tests for start with 2+ args in audiobuffersource-start.html. 
All webaudio layout tests pass.

[Ken Russell (switch to Gerrit), 2013/10/28 20:13:42]

I understand this, but the new code's behavior is significantly different when
calling the simplified start() compared to the version taking more arguments.
The simple start() method delegates up to the superclass, and I think that is a
bad idea, because it will cause the AudioBufferSourceNode to potentially get
into states that are unexpected, especially as the code base evolves.

Because AudioBufferSourceNode shadows some of the invocations of
AudioScheduledSourceNode::start it should shadow all of them. There should be
one start() declaration in the header, taking all three arguments as optional,
just like in the spec.

 }
 
-void AudioBufferSourceNode::startGrain(double when, double grainOffset, double grainDuration)
+void AudioBufferSourceNode::start(double when, double grainOffset, double grainDuration)
 {
     ASSERT(isMainThread());
 
     if (m_playbackState != UNSCHEDULED_STATE)
         return;
 
     if (!buffer())
         return;
 
     // Do sanity checking of grain parameters versus buffer size.
@@ skipping 19 matching lines @@
     // at a sub-sample position since it will degrade the quality.
     // When aligned to the sample-frame the playback will be identical to the PCM data stored in the buffer.
     // Since playbackRate == 1 is very common, it's worth considering quality.
     m_virtualReadIndex = AudioUtilities::timeToSampleFrame(m_grainOffset, buffer()->sampleRate());
 
     m_playbackState = SCHEDULED_STATE;
 }
 
 void AudioBufferSourceNode::noteGrainOn(double when, double grainOffset, double grainDuration)
 {
-    startGrain(when, grainOffset, grainDuration);
+    start(when, grainOffset, grainDuration);
 }
 
 double AudioBufferSourceNode::totalPitchRate()
 {
     double dopplerRate = 1.0;
     if (m_pannerNode)
         dopplerRate = m_pannerNode->dopplerRate();
 
     // Incorporate buffer's sample-rate versus AudioContext's sample-rate.
     // Normally it's not an issue because buffers are loaded at the AudioContext's sample-rate, but we can handle it in any case.
@@ skipping 47 matching lines @@
 void AudioBufferSourceNode::finish()
 {
     clearPannerNode();
     ASSERT(!m_pannerNode);
     AudioScheduledSourceNode::finish();
 }
 
 } // namespace WebCore
 
 #endif // ENABLE(WEB_AUDIO)