Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2691273002: Use kernel transformation and VmTarget. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, asgerf
Target Ref:
refs/heads/master
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -30 lines) Patch
M pkg/front_end/lib/src/fasta/analyzer/token_utils.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 4 chunks +4 lines, -20 lines 0 comments Download
M pkg/front_end/lib/src/fasta/loader.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/target_implementation.dart View 2 chunks +9 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/testing/suite.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/kernel/lib/transformations/setup_builtin_library.dart View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
3 years, 10 months ago (2017-02-14 13:55:48 UTC) #2
Johnni Winther
lgtm
3 years, 10 months ago (2017-02-14 14:14:18 UTC) #3
ahe
3 years, 10 months ago (2017-02-14 16:22:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fcb43a1fbf9eb9d774d5c1823566aeba5da4d658 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698