third_party/WebKit/LayoutTests/editing/style/justify-left-crash.html - Issue 2691243002: Revert of Make FrameSelection to hold non-canonicalized positions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/editing/style/justify-left-crash.html

Issue 2691243002: Revert of Make FrameSelection to hold non-canonicalized positions (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/selection/selection_remove_children.html ('k') | third_party/WebKit/LayoutTests/editing/undo/redo-selection-modify-crash.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/editing/style/justify-left-crash.html

diff --git a/third_party/WebKit/LayoutTests/editing/style/justify-left-crash.html b/third_party/WebKit/LayoutTests/editing/style/justify-left-crash.html

index 036af6712064d85427944c771506d774f917a1e9..18054a22032dee0a84033df3d975da66dee694ef 100644

--- a/third_party/WebKit/LayoutTests/editing/style/justify-left-crash.html

+++ b/third_party/WebKit/LayoutTests/editing/style/justify-left-crash.html

@@ -21,11 +21,9 @@

test(() => {

var sample = document.getElementById('sample');

assert_equals(sample.innerHTML, '<i>foo</i>');

- const selection = window.getSelection();

- assert_equals(selection.anchorNode, sample.firstChild.firstChild, 'anchorNode');

- assert_equals(selection.anchorOffset, 0, 'anchorOffset');

- assert_equals(selection.focusNode, sample.firstChild.firstChild, 'focusNode');

- assert_equals(selection.focusOffset, 3, 'focusOffset');

+ // TODO(yosin): Once we do lazy visible position canonicalization,

+ // we should have a caret.

+ assert_equals(getSelection().rangeCount, 0);

}, 'This is a crash test.');

</script>

</body>