Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: tools/traffic_annotation/sample_traffic_annotation.cc

Issue 2691233002: Updates in network traffic annotations proto definition. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/traffic_annotation/DEPS ('k') | tools/traffic_annotation/traffic_annotation.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/traffic_annotation/sample_traffic_annotation.cc
diff --git a/tools/traffic_annotation/sample_traffic_annotation.cc b/tools/traffic_annotation/sample_traffic_annotation.cc
index 552f301cfa6b5a148c446f6e80e373b9501d4f6f..717c789e27ca32070d40823abe849160f36d015e 100644
--- a/tools/traffic_annotation/sample_traffic_annotation.cc
+++ b/tools/traffic_annotation/sample_traffic_annotation.cc
@@ -6,7 +6,9 @@
// This file includes a sample and a template for text-coded traffic_annotation.
// For more description on each field, please refer to:
-// (tools/traffic_annotation/traffic_annotation.proto)
+// tools/traffic_annotation/traffic_annotation.proto
+// and
+// out/Debug/gen/components/policy/proto/cloud_policy.proto
// For more information on policies, please refer to:
// http://dev.chromium.org/administrators/policy-list-3
@@ -14,7 +16,7 @@ void network_traffic_annotation_sample() {
net::NetworkTrafficAnnotationTag traffic_annotation =
net::DefineNetworkTrafficAnnotation("spellcheck_lookup", R"(
semantics {
- sender: "spellcheck"
+ sender: "Spellcheck Lookup"
battre 2017/02/14 08:09:17 I think that "Spellcheck Lookup" is an operation b
Ramin Halavati 2017/02/14 08:12:40 Done.
description:
"Google Chrome can provide smarter spell-checking by sending "
"text you type into the browser to Google's servers, allowing "
@@ -47,23 +49,24 @@ void network_traffic_annotation_sample() {
void network_traffic_annotation_template() {
net::NetworkTrafficAnnotationTag traffic_annotation =
- net::DefineNetworkTrafficAnnotation("", R"(
+ net::DefineNetworkTrafficAnnotation("...", R"(
semantics {
- sender: ""
- description: ""
- trigger: ""
- data: ""
+ sender: "..."
+ description: "..."
+ trigger: "..."
+ data: "..."
destination: WEBSITE/GOOGLE_OWNED_SERVICE/OTHER
}
policy {
cookies_allowed: false/true
- cookies_store: ""
- setting: ""
+ cookies_store: "..."
+ setting: "..."
policy {
[POLICY_NAME] {
policy_options {mode: MANDATORY/RECOMMENDED/UNSET}
value: ...
}
}
+ policy_exception_justification = "..."
})");
}
« no previous file with comments | « tools/traffic_annotation/DEPS ('k') | tools/traffic_annotation/traffic_annotation.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698