Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: ui/gfx/color_space.h

Issue 2691213007: color: Don't use QCMS for transforms unless necessary (Closed)
Patch Set: Fix cache hit computation of parse result Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/color_space.h
diff --git a/ui/gfx/color_space.h b/ui/gfx/color_space.h
index 798b9305a19b28d5941eae06812167aa77fd23ae..84b5e23546523449884f16c8e5a1da356814e478 100644
--- a/ui/gfx/color_space.h
+++ b/ui/gfx/color_space.h
@@ -178,6 +178,11 @@ class GFX_EXPORT ColorSpace {
// range, and unspecified spaces.
sk_sp<SkColorSpace> ToSkColorSpace() const;
+ // Populate |icc_profile| with an ICC profile that represents this color
+ // space. Returns false if this space is not representable. This ICC profile
+ // will be constructed ignoring the range adjust and transfer matrices.
hubbe 2017/02/16 01:28:29 Ouch, if we can't represent those, shouldn't we ju
ccameron 2017/02/16 01:58:47 This is written with the IOSurface API in mind --
hubbe 2017/02/16 08:33:02 Can we add that to comment in the code, it doesn't
ccameron 2017/02/16 22:33:10 Good point -- done.
+ bool GetICCProfile(ICCProfile* icc_profile) const;
+
void GetPrimaryMatrix(SkMatrix44* to_XYZD50) const;
bool GetTransferFunction(SkColorSpaceTransferFn* fn) const;
bool GetInverseTransferFunction(SkColorSpaceTransferFn* fn) const;

Powered by Google App Engine
This is Rietveld 408576698