Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2691213005: Use identical in token operators. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, Johnni Winther
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Ensure operator names are canonicalized by deserializer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -20 lines) Patch
M pkg/compiler/lib/src/serialization/serialization.dart View 1 3 chunks +14 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/precedence.dart View 1 1 chunk +76 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/token.dart View 1 chunk +19 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ahe
3 years, 10 months ago (2017-02-15 10:13:36 UTC) #2
ahe
I believe I've fixed the problem with deserialization.
3 years, 10 months ago (2017-02-15 11:19:35 UTC) #3
karlklose
LGTM
3 years, 10 months ago (2017-02-15 11:28:30 UTC) #4
ahe
3 years, 10 months ago (2017-02-15 12:43:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4b206de3900ad27cf6b8f40c78dce2c8ada828f7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698