pylib/gyp/mac_tool.py - Issue 26912003: Fix warning linking static libraries on OS X 10.9

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/mac_tool.py

Issue 26912003: Fix warning linking static libraries on OS X 10.9 (Closed) Base URL: https://chromium.googlesource.com/external/gyp@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pylib/gyp/mac_tool.py

diff --git a/pylib/gyp/mac_tool.py b/pylib/gyp/mac_tool.py

index 3a28a17b949d5abab06a40455734c916031e481c..77116de875c898a2fdfbf9f08182aa1432f9aafc 100755

--- a/pylib/gyp/mac_tool.py

+++ b/pylib/gyp/mac_tool.py

@@ -201,7 +201,7 @@ class MacTool(object):

def ExecFilterLibtool(self, *cmd_list):

"""Calls libtool and filters out 'libtool: file: foo.o has no symbols'."""

Nico 2013/10/10 19:56:01 change the comment to say '/path/to/libtool: file:

- libtool_re = re.compile(r'^libtool: file: .* has no symbols$')

+ libtool_re = re.compile(r'^.*libtool: file: .* has no symbols$')

libtoolout = subprocess.Popen(cmd_list, stderr=subprocess.PIPE)

_, err = libtoolout.communicate()

for line in err.splitlines():

« no previous file with comments | « no previous file | no next file » | no next file with comments »