Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 26912003: Fix warning linking static libraries on OS X 10.9 (Closed)

Created:
7 years, 2 months ago by Jiang Jiang
Modified:
7 years, 1 month ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp@master
Visibility:
Public.

Description

Fix warning linking static libraries on OS X 10.9 libtool on OS X 10.9 will output message such as: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: file: gen/third_party/libvpx/x86inc.o has no symbols instead of libtool: file: gen/third_party/libvpx/x86inc.o has no symbols As a result, the pattern used by gyp-mac-tool to filter these kind of messages (r'libtool: file: .* has no symbols$') no longer works. Extend the pattern a little bit to support output with full directory names. gyp r1769

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M pylib/gyp/mac_tool.py View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jiang Jiang
I'm trying to building Opera/Chromium on OS X 10.9 GM (with Xcode 5.0.1 GM) and ...
7 years, 2 months ago (2013-10-10 19:44:23 UTC) #1
Nico
lgtm https://codereview.chromium.org/26912003/diff/1/pylib/gyp/mac_tool.py File pylib/gyp/mac_tool.py (right): https://codereview.chromium.org/26912003/diff/1/pylib/gyp/mac_tool.py#newcode203 pylib/gyp/mac_tool.py:203: """Calls libtool and filters out 'libtool: file: foo.o ...
7 years, 2 months ago (2013-10-10 19:56:01 UTC) #2
Jiang Jiang
On 2013/10/10 19:56:01, Nico wrote: > lgtm > > https://codereview.chromium.org/26912003/diff/1/pylib/gyp/mac_tool.py > File pylib/gyp/mac_tool.py (right): > ...
7 years, 2 months ago (2013-10-10 20:00:20 UTC) #3
Jiang Jiang
On 2013/10/10 20:00:20, Jiang wrote: > On 2013/10/10 19:56:01, Nico wrote: > > lgtm > ...
7 years, 2 months ago (2013-10-10 21:20:20 UTC) #4
Nico
7 years, 1 month ago (2013-11-17 10:05:42 UTC) #5
Message was sent while issue was closed.
I landed this over a month ago in gyp r1769, but didn't reply on this review,
sorry.

Powered by Google App Engine
This is Rietveld 408576698