content/browser/browser_plugin/browser_plugin_guest.h - Issue 269113002: Remove BrowserPluginGuestManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 269113002: Remove BrowserPluginGuestManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_createguest

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/browser_plugin/browser_plugin_embedder.cc ('K') | « content/browser/browser_plugin/browser_plugin_embedder.cc ('k') | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | content/browser/browser_plugin/browser_plugin_guest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_guest.h

diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h

index 835acb01dfb4fe6f69e0fed62e845a71042feac1..f066760d99ecb84ccb51728d9b6200c307073e45 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.h

+++ b/content/browser/browser_plugin/browser_plugin_guest.h

@@ -60,6 +60,7 @@ class Range;

namespace content {

class BrowserPluginGuestManager;

lazyboy 2014/05/05 21:40:54 Remove.

Fady Samuel 2014/05/07 17:32:59 Done.

+class BrowserPluginGuestManagerDelegate;

class BrowserPluginHostFactory;

class RenderWidgetHostView;

class SiteInstance;

@@ -150,7 +151,7 @@ class CONTENT_EXPORT BrowserPluginGuest

gfx::Size dst_size,

const base::Callback<void(bool, const SkBitmap&)>& callback);

- BrowserPluginGuestManager* GetBrowserPluginGuestManager() const;

+ BrowserPluginGuestManagerDelegate* GetBrowserPluginGuestManager() const;

// WebContentsObserver implementation.

virtual void DidCommitProvisionalLoadForFrame(