Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Issue 269113002: Remove BrowserPluginGuestManager (Closed)

Created:
6 years, 7 months ago by Fady Samuel
Modified:
6 years, 7 months ago
Reviewers:
lazyboy, jam
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@guestview_manager_createguest
Visibility:
Public.

Description

Remove BrowserPluginGuestManager This CL removes BrowserPluginGuestManager entirely, leaving BrowserPlugin relying on the BrowserPluginGuestManagerDelegate interface. This CL significantly reduces complexity in content. In a subsequent patch, BrowserPluginGuestManagerDelegate will be renamed BrowserPluginGuestManager. I am leaving that separate so it is clear what's going on. BUG=364141, 330264 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269680

Patch Set 1 #

Total comments: 14

Patch Set 2 : Updated #

Patch Set 3 : Addressed nits #

Patch Set 4 : Added a DCHECK #

Patch Set 5 : Updated #

Patch Set 6 : Updateed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -460 lines) Patch
M content/browser/browser_plugin/browser_plugin_embedder.h View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_embedder.cc View 1 2 7 chunks +25 lines, -19 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 2 3 6 chunks +15 lines, -8 lines 0 comments Download
D content/browser/browser_plugin/browser_plugin_guest_manager.h View 1 1 chunk +0 lines, -108 lines 0 comments Download
D content/browser/browser_plugin/browser_plugin_guest_manager.cc View 1 2 3 4 1 chunk +0 lines, -151 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_host_browsertest.cc View 7 chunks +9 lines, -35 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_host_factory.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_message_filter.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_message_filter.cc View 4 chunks +24 lines, -12 lines 0 comments Download
D content/browser/browser_plugin/test_browser_plugin_guest_manager.h View 1 2 3 4 5 1 chunk +0 lines, -50 lines 0 comments Download
D content/browser/browser_plugin/test_browser_plugin_guest_manager.cc View 1 2 3 4 5 1 chunk +0 lines, -55 lines 0 comments Download
M content/browser/browser_plugin/test_guest_manager_delegate.h View 1 2 3 4 5 3 chunks +9 lines, -1 line 0 comments Download
M content/browser/browser_plugin/test_guest_manager_delegate.cc View 1 2 3 4 5 4 chunks +22 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 chunks +2 lines, -3 lines 0 comments Download
M content/content_browser.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Fady Samuel
6 years, 7 months ago (2014-05-05 20:19:09 UTC) #1
Fady Samuel
6 years, 7 months ago (2014-05-05 20:34:44 UTC) #2
lazyboy
lgtm LGTM with nits. https://chromiumcodereview.appspot.com/269113002/diff/1/content/browser/browser_plugin/browser_plugin_embedder.cc File content/browser/browser_plugin/browser_plugin_embedder.cc (right): https://chromiumcodereview.appspot.com/269113002/diff/1/content/browser/browser_plugin/browser_plugin_embedder.cc#newcode179 content/browser/browser_plugin/browser_plugin_embedder.cc:179: BrowserPluginGuestManagerDelegate* guest_manager = Declare this ...
6 years, 7 months ago (2014-05-05 21:40:54 UTC) #3
Fady Samuel
I've addressed all Istiaque's comments. John, could you please take a look? https://codereview.chromium.org/269113002/diff/1/content/browser/browser_plugin/browser_plugin_embedder.cc File content/browser/browser_plugin/browser_plugin_embedder.cc ...
6 years, 7 months ago (2014-05-07 17:32:59 UTC) #4
jam
files outside of browser_plugin lgtm
6 years, 7 months ago (2014-05-07 17:46:35 UTC) #5
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 7 months ago (2014-05-10 13:06:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/269113002/100001
6 years, 7 months ago (2014-05-10 13:08:20 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-10 19:39:33 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-10 21:58:50 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/14732)
6 years, 7 months ago (2014-05-10 21:58:50 UTC) #10
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 7 months ago (2014-05-10 22:19:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/269113002/100001
6 years, 7 months ago (2014-05-10 22:20:42 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 01:34:33 UTC) #13
Message was sent while issue was closed.
Change committed as 269680

Powered by Google App Engine
This is Rietveld 408576698