Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: dart/editor/build/build.py

Issue 26911008: Version 0.7.6.5 (Closed) Base URL: http://dart.googlecode.com/svn/branches/0.7/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/tools/VERSION » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/editor/build/build.py
===================================================================
--- dart/editor/build/build.py (revision 28629)
+++ dart/editor/build/build.py (working copy)
@@ -882,29 +882,29 @@
f.extract(inifile.replace('\\','/'))
f.close()
else:
- subprocess.call(['unzip', zipFile, inifile], env=os.environ)
+ bot_utils.run(['unzip', zipFile, inifile], env=os.environ)
Modify64BitDartEditorIni(inifile)
if (basename.startswith('darteditor-win32-')):
- f = zipfile.ZipFile(zipFile, 'a')
- f.write(inifile.replace('\\','/'))
- f.close()
+ seven_zip = os.path.join(DART_DIR, 'third_party', '7zip', '7za.exe')
+ bot_utils.run([seven_zip, 'd', zipFile, inifile], env=os.environ)
+ bot_utils.run([seven_zip, 'a', zipFile, inifile], env=os.environ)
else:
- subprocess.call(['zip', '-d', zipFile, inifile], env=os.environ)
- subprocess.call(['zip', '-q', zipFile, inifile], env=os.environ)
+ bot_utils.run(['zip', '-d', zipFile, inifile], env=os.environ)
+ bot_utils.run(['zip', '-q', zipFile, inifile], env=os.environ)
os.remove(inifile)
# post-process the info.plist file
if (basename.startswith('darteditor-macos-')):
infofile = join('dart', 'DartEditor.app', 'Contents', 'Info.plist')
- subprocess.call(['unzip', zipFile, infofile], env=os.environ)
+ bot_utils.run(['unzip', zipFile, infofile], env=os.environ)
ReplaceInFiles(
[infofile],
[('<dict>',
'<dict>\n\t<key>NSHighResolutionCapable</key>\n\t\t<true/>')])
- subprocess.call(['zip', '-q', zipFile, infofile], env=os.environ)
+ bot_utils.run(['zip', '-q', zipFile, infofile], env=os.environ)
os.remove(infofile)
« no previous file with comments | « no previous file | dart/tools/VERSION » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698