Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 26911007: TransitionAndStoreStub bailout needs to transition (and store). (Closed)

Created:
7 years, 2 months ago by mvstanton
Modified:
7 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

TransitionAndStoreStub bailout needs to transition (and store). Performance regression found in test regress-2185-2.js. The problem was that the bailout method for TransitionAndStoreStub was not performing the appropriate transition. BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17216

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/ic.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M test/mjsunit/allocation-site-info.js View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
mvstanton
Hi Benedikt, PTAL, thx! --Michael
7 years, 2 months ago (2013-10-15 12:02:37 UTC) #1
Benedikt Meurer
LGTM with nits. Thanks Michael. https://codereview.chromium.org/26911007/diff/1/test/mjsunit/allocation-site-info.js File test/mjsunit/allocation-site-info.js (right): https://codereview.chromium.org/26911007/diff/1/test/mjsunit/allocation-site-info.js#newcode153 test/mjsunit/allocation-site-info.js:153: // to transition to ...
7 years, 2 months ago (2013-10-15 12:06:05 UTC) #2
mvstanton
thanks! https://codereview.chromium.org/26911007/diff/1/test/mjsunit/allocation-site-info.js File test/mjsunit/allocation-site-info.js (right): https://codereview.chromium.org/26911007/diff/1/test/mjsunit/allocation-site-info.js#newcode153 test/mjsunit/allocation-site-info.js:153: // to transition to the most general elements ...
7 years, 2 months ago (2013-10-15 12:41:53 UTC) #3
mvstanton
7 years, 2 months ago (2013-10-15 12:42:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r17216 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698