Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_writing_mode.cc

Issue 2691093004: Fix orthogonal mode legacy mismatch (Closed)
Patch Set: CR fixes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_writing_mode.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_writing_mode.cc b/third_party/WebKit/Source/core/layout/ng/ng_writing_mode.cc
index c9b65792a51ee43716898deb1b9603697c680471..b55cd1859332f5a9c872350cdba06cbaa2e8bef8 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_writing_mode.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_writing_mode.cc
@@ -4,6 +4,7 @@
#include "core/layout/ng/ng_writing_mode.h"
+#include "core/layout/LayoutObject.h"
#include "wtf/Assertions.h"
namespace blink {
@@ -22,4 +23,17 @@ NGWritingMode FromPlatformWritingMode(WritingMode mode) {
}
}
+bool IsParallelWritingMode(NGWritingMode a, NGWritingMode b) {
+ return (a == kHorizontalTopBottom) == (b == kHorizontalTopBottom);
+}
+
+bool IsParallelWritingMode(const LayoutObject* layoutObject,
+ const ComputedStyle& style) {
+ if (!layoutObject)
+ return true;
+ return IsParallelWritingMode(
+ FromPlatformWritingMode(layoutObject->styleRef().getWritingMode()),
+ FromPlatformWritingMode(style.getWritingMode()));
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698