third_party/WebKit/Source/core/dom/Document.cpp - Issue 2691083006: The security check in document.open should test for same-origin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2691083006: The security check in document.open should test for same-origin (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Document.cpp

diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp

index 4294b0b790cc03d931a4bfdf0e935993b5901ee8..dc5974ba26fa9533ccc3859d07c7794ee1d1ad18 100644

--- a/third_party/WebKit/Source/core/dom/Document.cpp

+++ b/third_party/WebKit/Source/core/dom/Document.cpp

@@ -2640,7 +2640,8 @@ void Document::open(Document* enteredDocument, ExceptionState& exceptionState) {

}

if (enteredDocument) {

- if (!getSecurityOrigin()->canAccess(enteredDocument->getSecurityOrigin())) {

+ if (!getSecurityOrigin()->isSameSchemeHostPortAndSuborigin(

+ enteredDocument->getSecurityOrigin())) {

exceptionState.throwSecurityError(

"Can only call open() on same-origin documents.");

return;