Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2378)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

Issue 2691073003: Add javatests for the WebView SafeBrowsing feature (Closed)
Patch Set: No sleeps, reduce duplicated code, switch to EmbeddedTestServer, etc. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java
index dd079f1baaf1f5969852bd23d70cc5c821062187..e0c3628d0f6c5e9974c355ca22034ef3cc6d0124 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java
@@ -104,11 +104,20 @@ public class AwTestBase
getInstrumentation().runOnMainSync(new Runnable() {
@Override
public void run() {
- mBrowserContext = new AwBrowserContext(prefs, appContext);
+ createAwBrowserContextHelper(prefs, appContext);
}
});
}
+ protected void createAwBrowserContextHelper(
boliu 2017/02/14 18:31:40 s/Helper/onUiThread/
Nate Fischer 2017/02/14 19:42:55 Done
+ InMemorySharedPreferences prefs, Context appContext) {
+ setBrowserContext(new AwBrowserContext(prefs, appContext));
+ }
+
+ protected void setBrowserContext(AwBrowserContext browserContext) {
boliu 2017/02/14 18:31:40 this should be private (or shouldn't exist at all)
Nate Fischer 2017/02/14 19:42:55 Done
+ mBrowserContext = browserContext;
+ }
+
protected void startBrowserProcess() throws Exception {
// The Activity must be launched in order for proper webview statics to be setup.
getActivity();

Powered by Google App Engine
This is Rietveld 408576698