Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(169)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: android_webview/test/data/iframe.html
Issue
2691073003
:
Add javatests for the WebView SafeBrowsing feature (Closed)
Patch Set: The callback helper approach didn't work, so just more carefully checks pixel color
Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
android_webview/javatests/DEPS
android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java
android_webview/javatests/src/org/chromium/android_webview/test/SafeBrowsingTest.java
android_webview/test/BUILD.gn
android_webview/test/data/green.html
android_webview/test/data/iframe.html
android_webview/test/data/malware.html
android_webview/test/data/safe.html
View unified diff
|
Download patch
« android_webview/javatests/src/org/chromium/android_webview/test/SafeBrowsingTest.java
('K') |
« android_webview/test/data/green.html
('k') |
android_webview/test/data/malware.html »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<html>
2
<head>
3
<style>
4
body {
5
background-color: rgb(0,0,0);
6
}
7
</style>
8
</head>
9
<body>
10
<iframe src="./malware.html"></iframe>
11
</body>
12
</html>
OLD
NEW
« android_webview/javatests/src/org/chromium/android_webview/test/SafeBrowsingTest.java
('K') |
« android_webview/test/data/green.html
('k') |
android_webview/test/data/malware.html »
('j') |
no next file with comments »
Issue 2691073003: Add javatests for the WebView SafeBrowsing feature (Closed)
Created 3 years, 10 months ago by Nate Fischer
Modified 3 years, 10 months ago
Reviewers: boliu, vakh (use Gerrit instead)
Base URL:
Comments: 25
This is Rietveld
408576698
Chromium Code Reviews
Issue 2691073003:
Add javatests for the WebView SafeBrowsing feature (Closed)
