arc: Use AndroidKioskAppInfoProto.display_name() as ARC++ Kiosk app name.

chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_manager_browsertest.cc

Index: chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_manager_browsertest.cc
diff --git a/chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_manager_browsertest.cc b/chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_manager_browsertest.cc
index 6586c012b387254bf3019eebfa004c62abfd6f27..bb1578332543e1fc68212cbc0bc086739e6f4f94 100644
--- a/chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_manager_browsertest.cc
+++ b/chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_manager_browsertest.cc
@@ -114,6 +114,9 @@ class ArcKioskAppManagerTest : public InProcessBrowserTest {
           kAccountsPrefDeviceLocalAccountsKeyArcKioskClass, app.class_name());
       entry->SetStringWithoutPathExpansion(
           kAccountsPrefDeviceLocalAccountsKeyArcKioskAction, app.action());
+      entry->SetStringWithoutPathExpansion(
+          kAccountsPrefDeviceLocalAccountsKeyArcKioskDisplayName,
+          app.display_name());
       device_local_accounts.Append(std::move(entry));
     }
     owner_settings_service_->Set(kAccountsPrefDeviceLocalAccounts,
@@ -143,9 +146,9 @@ class ArcKioskAppManagerTest : public InProcessBrowserTest {
 
 IN_PROC_BROWSER_TEST_F(ArcKioskAppManagerTest, Basic) {
   policy::ArcKioskAppBasicInfo app1("com.package.name1", std::string(),

[achuithb, 2017/02/16 13:41:45]

I think ("com.package.name1", "", "", "") would be better here

[Sergey Poromov, 2017/02/16 14:28:28]

Done.

-                                    std::string());
+                                    std::string(), std::string());
   policy::ArcKioskAppBasicInfo app2("com.package.name2", std::string(),
-                                    std::string());
+                                    std::string(), "display name");
   std::vector<policy::ArcKioskAppBasicInfo> init_apps{app1, app2};
 
   // Set initial list of apps.
@@ -160,6 +163,8 @@ IN_PROC_BROWSER_TEST_F(ArcKioskAppManagerTest, Basic) {
     ASSERT_EQ(2u, apps.size());
     ASSERT_EQ(app1, apps[0].app_info());
     ASSERT_EQ(app2, apps[1].app_info());
+    ASSERT_EQ(app1.package_name(), apps[0].name());
+    ASSERT_EQ(app2.display_name(), apps[1].name());
     EXPECT_FALSE(manager()->GetAutoLaunchAccountId().is_valid());
   }
 
@@ -178,6 +183,8 @@ IN_PROC_BROWSER_TEST_F(ArcKioskAppManagerTest, Basic) {
     ArcKioskAppManager::ArcKioskApps apps = manager()->GetAllApps();
     ASSERT_EQ(app1, apps[0].app_info());
     ASSERT_EQ(app2, apps[1].app_info());
+    ASSERT_EQ(app1.package_name(), apps[0].name());
+    ASSERT_EQ(app2.display_name(), apps[1].name());
     EXPECT_TRUE(manager()->GetAutoLaunchAccountId().is_valid());
     ASSERT_EQ(apps[1].account_id(), manager()->GetAutoLaunchAccountId());
   }
@@ -185,7 +192,7 @@ IN_PROC_BROWSER_TEST_F(ArcKioskAppManagerTest, Basic) {
   // Create a new list of apps, where there is no app2 (is auto launch now),
   // and present a new app.
   policy::ArcKioskAppBasicInfo app3("com.package.name3", std::string(),

[achuithb, 2017/02/16 13:41:45]

ditto

[Sergey Poromov, 2017/02/16 14:28:28]

Done.

-                                    std::string());
+                                    std::string(), std::string());
   std::vector<policy::ArcKioskAppBasicInfo> new_apps{app1, app3};
   {
     // Observer must be notified once: app list was updated.
@@ -198,6 +205,8 @@ IN_PROC_BROWSER_TEST_F(ArcKioskAppManagerTest, Basic) {
     ASSERT_EQ(2u, apps.size());
     ASSERT_EQ(app1, apps[0].app_info());
     ASSERT_EQ(app3, apps[1].app_info());
+    ASSERT_EQ(app1.package_name(), apps[0].name());
+    ASSERT_EQ(app3.package_name(), apps[1].name());
     // Auto launch app must be reset.
     EXPECT_FALSE(manager()->GetAutoLaunchAccountId().is_valid());
   }