Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2691043003: Remove unused TokenType.IS. (Closed)

Created:
3 years, 10 months ago by Paul Berry
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove unused TokenType.IS. TokenType is used for symbols, not keywords. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/02ff6326d75398b80e2093f50793ab0f9e94f023

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/ast_builder.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/scanner/token.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/front_end/test/scanner_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 10 months ago (2017-02-13 18:45:15 UTC) #2
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-13 19:01:35 UTC) #3
Paul Berry
3 years, 10 months ago (2017-02-13 19:17:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
02ff6326d75398b80e2093f50793ab0f9e94f023 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698