chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc - Issue 2691033008: MD Settings: Display a message when no other search engines exist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2691033008: MD Settings: Display a message when no other search engines exist. (Closed)

Patch Set: Add test. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engines_page.html ('k') | chrome/test/data/webui/settings/search_engines_page_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

index 985620119fc2316fd695d11cc5bbad81c1324863..7f3b668d897b18326799bbfda9d2b10b78b5814a 100644

--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

@@ -1502,6 +1502,7 @@ void AddSearchEnginesStrings(content::WebUIDataSource* html_source) {

{"searchEngines", IDS_SETTINGS_SEARCH_ENGINES},

{"searchEnginesDefault", IDS_SETTINGS_SEARCH_ENGINES_DEFAULT_ENGINES},

{"searchEnginesOther", IDS_SETTINGS_SEARCH_ENGINES_OTHER_ENGINES},

+ {"searchEnginesNoOther", IDS_SETTINGS_SEARCH_ENGINES_NO_OTHER_ENGINES},

tommycli 2017/02/16 02:09:51 nit: more verbose, but "searchEnginesNoOtherEngine

dpapad 2017/02/16 03:26:38 Done.

{"searchEnginesExtension", IDS_SETTINGS_SEARCH_ENGINES_EXTENSION_ENGINES},

{"searchEnginesSearchEngine", IDS_SETTINGS_SEARCH_ENGINES_SEARCH_ENGINE},

{"searchEnginesKeyword", IDS_SETTINGS_SEARCH_ENGINES_KEYWORD},