chrome/browser/resources/settings/search_engines_page/search_engines_page.html - Issue 2691033008: MD Settings: Display a message when no other search engines exist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engines_page.html

Issue 2691033008: MD Settings: Display a message when no other search engines exist. (Closed)

Patch Set: Add test. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc » ('j') | chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/search_engines_page.html

diff --git a/chrome/browser/resources/settings/search_engines_page/search_engines_page.html b/chrome/browser/resources/settings/search_engines_page/search_engines_page.html

index 6dc9f0d40a6b7209ecf475589cac8b4b45f8e33a..2b7c9e7b776d530fb00390379401efae4794027d 100644

--- a/chrome/browser/resources/settings/search_engines_page/search_engines_page.html

+++ b/chrome/browser/resources/settings/search_engines_page/search_engines_page.html

@@ -12,7 +12,8 @@

<dom-module id="settings-search-engines-page">

- .extension-engines {

+ .extension-engines,

+ #noOtherEngines {

@apply(--settings-list-frame-padding);

}

@@ -36,6 +37,9 @@

$i18n{add}

</paper-button>

</div>

+ <div id="noOtherEngines" hidden="[[otherEngines.length]]">

+ $i18n{searchEnginesNoOther}

+ </div>

<settings-search-engines-list engines="[[otherEngines]]" hide-headers>

</settings-search-engines-list>