Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1373)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java

Issue 2691033007: [Android] Fix a custom search engine bounces when it selected and unselected as default engine (Closed)
Patch Set: Update based on Ted's nits. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java b/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
index 85a498e83bf5a2b06ccf78df96ddcc6802a1caf2..9fb115595b264ddefdd214970aa51f38e033cddc 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
@@ -119,9 +119,8 @@ public class TemplateUrlService {
public boolean equals(Object other) {
if (!(other instanceof TemplateUrl)) return false;
TemplateUrl otherTemplateUrl = (TemplateUrl) other;
- // Explicitly excluding mTemplateUrlType as that will change if the search engine is
- // set as default.
return mIndex == otherTemplateUrl.mIndex
+ && mTemplateUrlType == otherTemplateUrl.mTemplateUrlType
&& mIsPrepopulated == otherTemplateUrl.mIsPrepopulated
&& TextUtils.equals(mKeyword, otherTemplateUrl.mKeyword)
&& TextUtils.equals(mShortName, otherTemplateUrl.mShortName);
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698