Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: components/browser_watcher/stability_report.proto

Issue 2691033002: Collect field trial information from the stability file (Closed)
Patch Set: Address rkaplow's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/browser_watcher/postmortem_report_collector_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browser_watcher/stability_report.proto
diff --git a/components/browser_watcher/stability_report.proto b/components/browser_watcher/stability_report.proto
index 7f20f7d5841c9aba8050ca69bde7372ab51a42ee..b5039a23e83b4835b100fae1ab813792daa4ad83 100644
--- a/components/browser_watcher/stability_report.proto
+++ b/components/browser_watcher/stability_report.proto
@@ -150,10 +150,24 @@ message ProcessState {
// TODO(manzagop): add experiment state.
}
+// Description of a field trial or experiment that the user is currently
+// enrolled in. This message is an analogue of the UMA proto in
+// components/metrics/proto/system_profile.proto. For details about generating
+// the identifiers from the field trial and group names, see
+// variations::MakeActiveGroupId().
+// Next id: 3
+message FieldTrial {
+ // A 32-bit identifier for the name of the field trial.
+ optional fixed32 name_id = 1;
+
+ // A 32-bit identifier for the user's group within the field trial.
+ optional fixed32 group_id = 2;
+}
+
// A stability report contains information pertaining to the execution of a
// single logical instance of a "chrome browser". It is comprised of information
// about the system state and about the chrome browser's processes.
-// Next id: 5
+// Next id: 6
message StabilityReport {
optional SystemState system_state = 1;
// TODO(manzagop): revisit whether a single repeated field should contain all
@@ -166,4 +180,7 @@ message StabilityReport {
// relocate these to their process (and perhaps thread).
repeated string log_messages = 3;
map<string, TypedValue> global_data = 4;
+
+ // The field trials the user is currently enrolled in.
+ repeated FieldTrial field_trials = 5;
}
« no previous file with comments | « components/browser_watcher/postmortem_report_collector_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698