Collect field trial information from the stability file

components/browser_watcher/postmortem_report_collector_unittest.cc

Index: components/browser_watcher/postmortem_report_collector_unittest.cc
diff --git a/components/browser_watcher/postmortem_report_collector_unittest.cc b/components/browser_watcher/postmortem_report_collector_unittest.cc
index 8d8d5cc4130ef63909db4349b724924b4388888d..f8d9c94ec6fe79dab10ddea0938bc9d1da9a7aca 100644
--- a/components/browser_watcher/postmortem_report_collector_unittest.cc
+++ b/components/browser_watcher/postmortem_report_collector_unittest.cc
@@ -650,6 +650,38 @@ TEST_F(PostmortemReportCollectorCollectionFromGlobalTrackerTest,
 }
 
 TEST_F(PostmortemReportCollectorCollectionFromGlobalTrackerTest,
+       FieldTrialCollection) {
+  // Record some data.
+  GlobalActivityTracker::CreateWithFile(debug_file_path(), kMemorySize, 0ULL,
+                                        "", 3);
+  ActivityUserData& global_data = GlobalActivityTracker::Get()->global_data();
+  global_data.SetString("string", "bar");
+  global_data.SetString("FieldTrial.string", "bar");
+  global_data.SetString("FieldTrial.foo", "bar");
+
+  // Collect the stability report.
+  PostmortemReportCollector collector(kProductName, kVersionNumber,
+                                      kChannelName);
+  std::unique_ptr<StabilityReport> report;
+  ASSERT_EQ(PostmortemReportCollector::SUCCESS,
+            collector.Collect(debug_file_path(), &report));
+  ASSERT_NE(nullptr, report);
+
+  // Validate the report's experiment and global data.
+  ASSERT_EQ(2, report->field_trials_size());

[rkaplow, 2017/02/16 21:27:28]

are you using an assert here because you want the following expect to not ever
be out of range (and give an out of bounds error, I guess?)

[manzagop (departed), 2017/02/17 22:20:05]

Yes!

+  EXPECT_NE(0U, report->field_trials(0).name_id());
+  EXPECT_NE(0U, report->field_trials(0).group_id());
+  EXPECT_NE(0U, report->field_trials(1).name_id());
+  EXPECT_EQ(report->field_trials(0).group_id(),
+            report->field_trials(1).group_id());
+
+  // Expect 5 key/value pairs (including product details).
+  const auto& collected_data = report->global_data();
+  ASSERT_EQ(5U, collected_data.size());

[rkaplow, 2017/02/16 21:27:28]

can't these safely be expects though?

[manzagop (departed), 2017/02/17 22:20:05]

Yes!

+  ASSERT_TRUE(base::ContainsKey(collected_data, "string"));
+}
+
+TEST_F(PostmortemReportCollectorCollectionFromGlobalTrackerTest,
        ModuleCollection) {
   // Record some module information.
   GlobalActivityTracker::CreateWithFile(debug_file_path(), kMemorySize, 0ULL,