Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Side by Side Diff: components/browser_watcher/stability_report.proto

Issue 2691033002: Collect field trial information from the stability file (Closed)
Patch Set: Merge Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 syntax = "proto2"; 5 syntax = "proto2";
6 6
7 option optimize_for = LITE_RUNTIME; 7 option optimize_for = LITE_RUNTIME;
8 8
9 package browser_watcher; 9 package browser_watcher;
10 10
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 // The identifier of the process. 141 // The identifier of the process.
142 optional int64 process_id = 3; 142 optional int64 process_id = 3;
143 143
144 // Note: likely only a subset of modules of interest (e.g. Chromium's own 144 // Note: likely only a subset of modules of interest (e.g. Chromium's own
145 // modules). 145 // modules).
146 repeated CodeModule modules = 1; 146 repeated CodeModule modules = 1;
147 repeated ThreadState threads = 2; 147 repeated ThreadState threads = 2;
148 // TODO(manzagop): add experiment state. 148 // TODO(manzagop): add experiment state.
149 } 149 }
150 150
151 // Description of a field trial or experiment that the user is currently
152 // enrolled in.
153 // Next id: 3
154 message FieldTrial {
155 // The name of the field trial, as a 32-bit identifier.
156 optional fixed32 name_id = 1;
157
158 // The user's group within the field trial, as a 32-bit identifier.
159 optional fixed32 group_id = 2;
160 }
161
151 // A stability report contains information pertaining to the execution of a 162 // A stability report contains information pertaining to the execution of a
152 // single logical instance of a "chrome browser". It is comprised of information 163 // single logical instance of a "chrome browser". It is comprised of information
153 // about the system state and about the chrome browser's processes. 164 // about the system state and about the chrome browser's processes.
154 // Next id: 5 165 // Next id: 6
155 message StabilityReport { 166 message StabilityReport {
156 optional SystemState system_state = 1; 167 optional SystemState system_state = 1;
157 // TODO(manzagop): revisit whether a single repeated field should contain all 168 // TODO(manzagop): revisit whether a single repeated field should contain all
158 // processes, or whether it's preferable to have separate fields per type. 169 // processes, or whether it's preferable to have separate fields per type.
159 // TODO(manzagop): add information about the type of process, pid, process 170 // TODO(manzagop): add information about the type of process, pid, process
160 // times (e.g. start time), hierarchical relationships (e.g. parent pid), 171 // times (e.g. start time), hierarchical relationships (e.g. parent pid),
161 // command line, etc. 172 // command line, etc.
162 repeated ProcessState process_states = 2; 173 repeated ProcessState process_states = 2;
163 // TODO(manzagop): if/when reports contain multiple processes, attribute and 174 // TODO(manzagop): if/when reports contain multiple processes, attribute and
164 // relocate these to their process (and perhaps thread). 175 // relocate these to their process (and perhaps thread).
165 repeated string log_messages = 3; 176 repeated string log_messages = 3;
166 map<string, TypedValue> global_data = 4; 177 map<string, TypedValue> global_data = 4;
178
179 // The field trials the user is currently enrolled in.
180 repeated FieldTrial field_trials = 5;
167 } 181 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698