Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: components/browser_watcher/stability_report.proto

Issue 2691033002: Collect field trial information from the stability file (Closed)
Patch Set: Fix test post merge Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 syntax = "proto2"; 5 syntax = "proto2";
6 6
7 option optimize_for = LITE_RUNTIME; 7 option optimize_for = LITE_RUNTIME;
8 8
9 package browser_watcher; 9 package browser_watcher;
10 10
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 // The identifier of the process. 143 // The identifier of the process.
144 optional int64 process_id = 3; 144 optional int64 process_id = 3;
145 145
146 // Note: likely only a subset of modules of interest (e.g. Chromium's own 146 // Note: likely only a subset of modules of interest (e.g. Chromium's own
147 // modules). 147 // modules).
148 repeated CodeModule modules = 1; 148 repeated CodeModule modules = 1;
149 repeated ThreadState threads = 2; 149 repeated ThreadState threads = 2;
150 // TODO(manzagop): add experiment state. 150 // TODO(manzagop): add experiment state.
151 } 151 }
152 152
153 // Description of a field trial or experiment that the user is currently
rkaplow 2017/02/16 21:27:28 can you add pointers to the uma proto which stores
manzagop (departed) 2017/02/17 22:20:05 Done.
154 // enrolled in.
155 // Next id: 3
156 message FieldTrial {
157 // The name of the field trial, as a 32-bit identifier.
158 optional fixed32 name_id = 1;
159
160 // The user's group within the field trial, as a 32-bit identifier.
161 optional fixed32 group_id = 2;
162 }
163
153 // A stability report contains information pertaining to the execution of a 164 // A stability report contains information pertaining to the execution of a
154 // single logical instance of a "chrome browser". It is comprised of information 165 // single logical instance of a "chrome browser". It is comprised of information
155 // about the system state and about the chrome browser's processes. 166 // about the system state and about the chrome browser's processes.
156 // Next id: 5 167 // Next id: 6
157 message StabilityReport { 168 message StabilityReport {
158 optional SystemState system_state = 1; 169 optional SystemState system_state = 1;
159 // TODO(manzagop): revisit whether a single repeated field should contain all 170 // TODO(manzagop): revisit whether a single repeated field should contain all
160 // processes, or whether it's preferable to have separate fields per type. 171 // processes, or whether it's preferable to have separate fields per type.
161 // TODO(manzagop): add information about the type of process, pid, process 172 // TODO(manzagop): add information about the type of process, pid, process
162 // times (e.g. start time), hierarchical relationships (e.g. parent pid), 173 // times (e.g. start time), hierarchical relationships (e.g. parent pid),
163 // command line, etc. 174 // command line, etc.
164 repeated ProcessState process_states = 2; 175 repeated ProcessState process_states = 2;
165 // TODO(manzagop): if/when reports contain multiple processes, attribute and 176 // TODO(manzagop): if/when reports contain multiple processes, attribute and
166 // relocate these to their process (and perhaps thread). 177 // relocate these to their process (and perhaps thread).
167 repeated string log_messages = 3; 178 repeated string log_messages = 3;
168 map<string, TypedValue> global_data = 4; 179 map<string, TypedValue> global_data = 4;
180
181 // The field trials the user is currently enrolled in.
182 repeated FieldTrial field_trials = 5;
169 } 183 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698