Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: milo/appengine/frontend/static/common/js/time.js

Issue 2691003002: Display "(local time)" label after start/end time of the build (Closed)
Patch Set: Addressed comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/frontend/static/common/js/time.js
diff --git a/milo/appengine/frontend/static/common/js/time.js b/milo/appengine/frontend/static/common/js/time.js
index c2e1da0c78f19280456680ed370683c7ab4994a9..c70ed97664036b96d416fce6d93b71598dafc4c2 100644
--- a/milo/appengine/frontend/static/common/js/time.js
+++ b/milo/appengine/frontend/static/common/js/time.js
@@ -18,15 +18,6 @@
return null;
}
var shortDayNames = ['Sun', 'Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat'];
- var offset = -(new Date()).getTimezoneOffset();
- var offsetHr = Math.abs(Math.round(offset / 60));
- var offsetMin = Math.abs(Math.abs(offset) - (offsetHr * 60));
- if (offsetHr < 10) {
- offsetHr = '0' + offsetHr;
- }
- if (offsetMin < 10) {
- offsetMin = '0' + offsetMin;
- }
var month = (t.getMonth() + 1);
if (month < 10) {
@@ -38,7 +29,7 @@
}
var s = shortDayNames[t.getDay()] + ', ';
s += t.getFullYear() + '-' + month + '-' + date + ' ';
- s += t.toLocaleTimeString();
+ s += t.toLocaleTimeString() + ' (local time)';
mithro 2017/03/02 06:29:23 This text is not useful, who's local time? Please
return s;
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698