Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 269095: NTP: Fix startup visual state ... (Closed)

Created:
11 years, 2 months ago by arv (Not doing code reviews)
Modified:
9 years, 3 months ago
Reviewers:
Miranda Callahan
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

NTP: Fix startup visual state This inject the template data earlier in the document so that we can set the initial visual state based on the user preference. This prevents flickering when the user is not showing the most visited thumbnails. BUG=24513 TEST=Use a theme with a background image to make this easier to spot. Hide the most visited. Restart Chrome. The thumbnails should not flicker

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -313 lines) Patch
M chrome/browser/dom_ui/new_tab_ui.cc View 1 2 3 4 5 2 chunks +16 lines, -2 lines 0 comments Download
M chrome/browser/resources/new_new_tab.css View 1 2 3 4 5 5 chunks +15 lines, -57 lines 0 comments Download
M chrome/browser/resources/new_new_tab.html View 1 2 3 4 5 6 chunks +126 lines, -112 lines 0 comments Download
M chrome/browser/resources/new_new_tab.js View 1 2 3 4 5 6 14 chunks +20 lines, -140 lines 0 comments Download
M chrome/common/jstemplate_builder.cc View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
arv (Not doing code reviews)
11 years, 2 months ago (2009-10-15 18:59:36 UTC) #1
Miranda Callahan
Hmm -- I just tried this patch out, and when I go to list view ...
11 years, 2 months ago (2009-10-15 19:36:38 UTC) #2
arv (Not doing code reviews)
You are correct. I can't believe I missed that. I must have reloaded the page ...
11 years, 2 months ago (2009-10-15 20:38:47 UTC) #3
arv (Not doing code reviews)
PTAL
11 years, 2 months ago (2009-10-15 22:18:33 UTC) #4
arv (Not doing code reviews)
I find the layout code to be really ugly. I think I might take a ...
11 years, 2 months ago (2009-10-15 22:28:53 UTC) #5
mirandac
That's fine -- just ping me when you want the review. On Thu, Oct 15, ...
11 years, 2 months ago (2009-10-15 22:38:12 UTC) #6
Miranda Callahan
11 years, 2 months ago (2009-10-16 00:37:41 UTC) #7
lgtm!

On 2009/10/15 22:38:12, mirandac_google.com wrote:
> That's fine -- just ping me when you want the review.
> 
> On Thu, Oct 15, 2009 at 3:28 PM, <mailto:arv@chromium.org> wrote:
> 
> > I find the layout code to be really ugly. I think I might take a stab at
> > cleaning it up.
> >
> >
> > http://codereview.chromium.org/269095
> >
>

Powered by Google App Engine
This is Rietveld 408576698