remoting/client/plugin/pepper_video_renderer_3d.h - Issue 2690943005: Updating OnPictureReady() method name per CR feedback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/plugin/pepper_video_renderer_3d.h

Issue 2690943005: Updating OnPictureReady() method name per CR feedback (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/client/plugin/pepper_video_renderer_3d.h

diff --git a/remoting/client/plugin/pepper_video_renderer_3d.h b/remoting/client/plugin/pepper_video_renderer_3d.h

index 23494640769be24cc7439b3c29e8c6e7cb8fce91..807019e535ddcd3e2a6bf51b49344f9b1a1d2f38 100644

--- a/remoting/client/plugin/pepper_video_renderer_3d.h

+++ b/remoting/client/plugin/pepper_video_renderer_3d.h

@@ -71,8 +71,8 @@ class PepperVideoRenderer3D : public PepperVideoRenderer,

// Callback for pp::VideoDecoder::Decode().

void OnDecodeDone(int32_t result);

- // Fetches next picture from the |video_decoder_|.

- void GetNextPicture();

+ // Fetches next picture from the |video_decoder_| if a decoded frame is ready.

+ void GetNextPictureIfReady();

// Callback for pp::VideoDecoder::GetPicture().

void OnPictureReady(int32_t result, PP_VideoPicture picture);