Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1390)

Unified Diff: net/socket/ssl_client_socket_unittest.cc

Issue 2690943004: Add ReadIfReady() for tcp_socket_win (Closed)
Patch Set: rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/socket/tcp_socket_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket_unittest.cc
diff --git a/net/socket/ssl_client_socket_unittest.cc b/net/socket/ssl_client_socket_unittest.cc
index d7d28bc556e857420d05c5470be0ff84fa6c6d71..5040a388491791abef2d868546470fa1260bee1d 100644
--- a/net/socket/ssl_client_socket_unittest.cc
+++ b/net/socket/ssl_client_socket_unittest.cc
@@ -3775,14 +3775,7 @@ TEST_P(SSLClientSocketReadTest, DumpMemoryStats) {
StreamSocket::SocketMemoryStats stats2;
sock_->DumpMemoryStats(&stats2);
- bool buffer_released = false;
if (read_if_ready_enabled()) {
-// TODO(xunjieli): https://crbug.com/690915. Implement for windows.
-#if defined(OS_POSIX)
- buffer_released = true;
-#endif
- }
- if (buffer_released) {
EXPECT_EQ(0u, stats2.buffer_size);
EXPECT_EQ(stats.cert_size, stats2.total_size);
} else {
« no previous file with comments | « no previous file | net/socket/tcp_socket_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698