Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

Issue 2690943002: Revert of binding: Changes the association among global-proxy/global/window-instance. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
index 4c0255f49b756c312fa932cfbc2e30371ce90fff..0d099ccade7b45cb3ee7e2b38107e2ec856cc787 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
@@ -468,9 +468,7 @@
class DOMWrapperTracer : public v8::PersistentHandleVisitor {
public:
- explicit DOMWrapperTracer(Visitor* visitor) : m_visitor(visitor) {
- DCHECK(m_visitor);
- }
+ explicit DOMWrapperTracer(Visitor* visitor) : m_visitor(visitor) {}
void VisitPersistentHandle(v8::Persistent<v8::Value>* value,
uint16_t classId) override {
@@ -481,8 +479,8 @@
const v8::Persistent<v8::Object>& wrapper =
v8::Persistent<v8::Object>::Cast(*value);
- if (ScriptWrappable* scriptWrappable = toScriptWrappable(wrapper))
- toWrapperTypeInfo(wrapper)->trace(m_visitor, scriptWrappable);
+ if (m_visitor)
+ toWrapperTypeInfo(wrapper)->trace(m_visitor, toScriptWrappable(wrapper));
}
private:
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h ('k') | third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698