third_party/WebKit/Source/core/dom/ExecutionContext.cpp - Issue 2690933003: Don't sanitize errors if the protocol is "data:"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ExecutionContext.cpp

Issue 2690933003: Don't sanitize errors if the protocol is "data:" (Closed)

Patch Set: Removed the runtime-error-data-url-expected.txt file since both tests in it are now passing Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/ExecutionContext.cpp

diff --git a/third_party/WebKit/Source/core/dom/ExecutionContext.cpp b/third_party/WebKit/Source/core/dom/ExecutionContext.cpp

index 149cd19ff7be676ed587f3f375502f10e036290a..664bcda9343c1fe53de02683268aa657c7833e98 100644

--- a/third_party/WebKit/Source/core/dom/ExecutionContext.cpp

+++ b/third_party/WebKit/Source/core/dom/ExecutionContext.cpp

@@ -98,7 +98,10 @@ bool ExecutionContext::shouldSanitizeScriptError(

AccessControlStatus corsStatus) {

if (corsStatus == OpaqueResource)

return true;

- return !(getSecurityOrigin()->canRequestNoSuborigin(completeURL(sourceURL)) ||

+ const KURL& url = completeURL(sourceURL);

+ if (url.protocolIsData())

+ return false;

+ return !(getSecurityOrigin()->canRequestNoSuborigin(url) ||

corsStatus == SharableCrossOrigin);

}