third_party/WebKit/LayoutTests/http/tests/security/script-dataurl-not-sanitized.html - Issue 2690933003: Don't sanitize errors if the protocol is "data:"

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/security/script-dataurl-not-sanitized.html

Issue 2690933003: Don't sanitize errors if the protocol is "data:" (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	Mike West 2017/02/14 07:19:07 It looks like there's an existing test in https:// It looks like there's an existing test in https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/.... Why don't we update that test a bit to test more of the error event (and to change the misleading "same-origin" comment) and unskip it in TestExpectations rather than adding a new test? andypaicu2 2017/02/14 09:09:22 Done Show quoted text On 2017/02/14 at 07:19:07, Mike West (sloooooow) wrote: > It looks like there's an existing test in https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/.... Why don't we update that test a bit to test more of the error event (and to change the misleading "same-origin" comment) and unskip it in TestExpectations rather than adding a new test? Done
	2 <title>Data URLs error messages are not sanitized</title>

	3 <script src="../resources/testharness.js"></script>

	4 <script src="../resources/testharnessreport.js"></script>

	5 <div id="log"></div>

	6 <script>

	7 async_test(function(t) {

	8 window.onerror = t.step_func_done(function(msg, url, line, col, error) {

	9 assert_not_equals(msg, 'Script error.');

	10 assert_equals(url, "data:application/javascript,throw 'This%20is%20an%20erro r%20message'");

	11 assert_not_equals(line, 0);

	12 assert_not_equals(col, 0);

	13 assert_not_equals(error, null);

	14 });

	15 }, "Data URLs error messages are not sanitized");

	16 </script>

	17 <script src="data:application/javascript,throw 'This%20is%20an%20error%20message '"></script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/ExecutionContext.cpp » ('j') | no next file with comments »