Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Issue 2690923004: Only capture function instantiator when compiling local function (fixes #28757). (Closed)

Created:
3 years, 10 months ago by regis
Modified:
3 years, 10 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Only capture function instantiator when compiling local function (fixes #28757). Note that this code has no effect yet, because generic functions are not yet fully supported (no regression test added). R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/339d16fbc5d611fbbcf46235c290c615589ecc87

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M runtime/vm/parser.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
3 years, 10 months ago (2017-02-14 09:45:55 UTC) #2
hausner
lgtm
3 years, 10 months ago (2017-02-14 09:50:52 UTC) #3
regis
3 years, 10 months ago (2017-02-14 09:55:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
339d16fbc5d611fbbcf46235c290c615589ecc87 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698