Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: components/sync/model_impl/processor_entity_tracker.h

Issue 2690913005: [Sync] Update EntityData on all codepaths from model type sync bridge (Closed)
Patch Set: Address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/sync/model_impl/processor_entity_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/model_impl/processor_entity_tracker.h
diff --git a/components/sync/model_impl/processor_entity_tracker.h b/components/sync/model_impl/processor_entity_tracker.h
index 718c3c725effec3428e33511b663ffd458106859..9d4ded7588ed2129c30aa3a0abf9e9f9f6c31cf3 100644
--- a/components/sync/model_impl/processor_entity_tracker.h
+++ b/components/sync/model_impl/processor_entity_tracker.h
@@ -100,9 +100,10 @@ class ProcessorEntityTracker {
// Clears any in-memory sync state associated with outstanding commits.
void ClearTransientSyncState();
- // Takes the passed commit data and caches it in the instance.
- // The data is swapped from the input struct without copying.
- void CacheCommitData(EntityData* data);
+ // Takes the passed commit data updates its fields with values from metadata
+ // and caches it in the instance. The data is swapped from the input struct
+ // without copying.
+ void SetCommitData(EntityData* data);
// Caches the a copy of |data_ptr|, which doesn't copy the data itself.
void CacheCommitData(const EntityDataPtr& data_ptr);
« no previous file with comments | « no previous file | components/sync/model_impl/processor_entity_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698