Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2690913004: Add a BUILD target and a script to build a public static library for ios/web_view.

Created:
3 years, 10 months ago by michaeldo
Modified:
3 years, 10 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a BUILD target and a script to build a public static library for ios/web_view. This is a rebase of https://codereview.chromium.org/2665333002/ based on the conversion of ios/web_view/internal to ARC. BUG=690805

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -25 lines) Patch
M ios/web_view/BUILD.gn View 1 chunk +24 lines, -2 lines 0 comments Download
M ios/web_view/internal/BUILD.gn View 2 chunks +62 lines, -22 lines 0 comments Download
A ios/web_view/internal/hide_symbols.py View 1 chunk +85 lines, -0 lines 0 comments Download
M ios/web_view/shell/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
michaeldo
3 years, 10 months ago (2017-02-13 21:24:48 UTC) #3
Eugene But (OOO till 7-30)
lgtm
3 years, 10 months ago (2017-02-13 23:16:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690913004/1
3 years, 10 months ago (2017-02-13 23:17:40 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 23:35:09 UTC) #9
Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

Powered by Google App Engine
This is Rietveld 408576698