Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: third_party/WebKit/Source/platform/heap/Heap.cpp

Issue 2690913002: Thread-local weak processing should just use a global weak callback stacks (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/Heap.cpp
diff --git a/third_party/WebKit/Source/platform/heap/Heap.cpp b/third_party/WebKit/Source/platform/heap/Heap.cpp
index c35427805c97a2dc9e2db72ebea7fbfa64182bd2..7d17740fb56c7733274b6a036c0116549111fb1a 100644
--- a/third_party/WebKit/Source/platform/heap/Heap.cpp
+++ b/third_party/WebKit/Source/platform/heap/Heap.cpp
@@ -314,8 +314,8 @@ void ThreadHeap::pushThreadLocalWeakCallback(void* closure,
WeakCallback callback) {
ASSERT(ThreadState::current()->isInGC());
- ThreadState* state = pageFromObject(object)->arena()->getThreadState();
- state->pushThreadLocalWeakCallback(closure, callback);
+ CallbackStack::Item* slot = m_globalWeakCallbackStack->allocateEntry();
+ *slot = CallbackStack::Item(closure, callback);
}
bool ThreadHeap::popAndInvokeGlobalWeakCallback(Visitor* visitor) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698