Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: tests/language/language_kernel.status

Issue 2690873005: Enable causal stacktrace in kernel (Closed)
Patch Set: Change kernel function 'debuggable' field to an 'originalAsyncMarker' field, use it to set function… Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/kernel_to_il.cc ('K') | « runtime/vm/kernel_to_il.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/language_kernel.status
diff --git a/tests/language/language_kernel.status b/tests/language/language_kernel.status
index 5a7362765ba38ae40e460f5fdf32667999e438ad..97772c929de34386e26348a87549bf2516a657fa 100644
--- a/tests/language/language_kernel.status
+++ b/tests/language/language_kernel.status
@@ -44,7 +44,7 @@ vm/debug_break_enabled_vm_test/01: CompileTimeError
vm/debug_break_enabled_vm_test/none: CompileTimeError
vm/reflect_core_vm_test: CompileTimeError
vm/regress_27201_test: CompileTimeError
-vm/regress_28325_test: RuntimeError # Issue 28055.
+# vm/regress_28325_test: RuntimeError # Issue 28055. Passes by mistake.
Kevin Millikin (Google) 2017/02/22 10:42:18 Uncomment the line and give it an expectation of P
jensj 2017/02/23 09:40:26 Done.
# dartk: JIT failures
[ $compiler == dartk && $runtime == vm ]
@@ -203,9 +203,8 @@ library_env_test/has_no_mirror_support: RuntimeError
main_not_a_function_test/01: Crash
redirecting_factory_reflection_test: RuntimeError
-# Casual async stack traces are not implemented for Kernel.
+# Casual async stack traces does not give exactly same stacktrace on kernel
vm/causal_async_exception_stack_test: RuntimeError
Kevin Millikin (Google) 2017/02/22 10:42:18 I think this might be caused by not setting the pa
jensj 2017/02/23 09:40:26 It seems you are correct. It passes now.
-vm/causal_async_exception_stack2_test: RuntimeError
# dartk: JIT failures (debug)
[ $compiler == dartk && $runtime == vm && $mode == debug ]
« runtime/vm/kernel_to_il.cc ('K') | « runtime/vm/kernel_to_il.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698