pkg/kernel/lib/ast.dart - Issue 2690873005: Enable causal stacktrace in kernel - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(284)

My Issues | Starred Open | Closed | All

Unified Diff: pkg/kernel/lib/ast.dart

Issue 2690873005: Enable causal stacktrace in kernel (Closed)

Patch Set: Change kernel function 'debuggable' field to an 'originalAsyncMarker' field, use it to set function… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « pkg/kernel/binary.md ('k') | pkg/kernel/lib/binary/ast_from_binary.dart » ('j') | pkg/kernel/lib/transformations/continuation.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/kernel/lib/ast.dart

diff --git a/pkg/kernel/lib/ast.dart b/pkg/kernel/lib/ast.dart

index 2f3cb111d74337e809f435bacbdfa2000ae8f9db..60544c9894800be38e684f0de0d6e792f94e7a5d 100644

--- a/pkg/kernel/lib/ast.dart

+++ b/pkg/kernel/lib/ast.dart

@@ -1151,7 +1151,7 @@ class FunctionNode extends TreeNode {

int fileEndOffset = TreeNode.noOffset;

AsyncMarker asyncMarker;

- bool debuggable = true;

+ AsyncMarker originalAsyncMarker;

List<TypeParameter> typeParameters;

int requiredParameterCount;

List<VariableDeclaration> positionalParameters;

@@ -1167,7 +1167,8 @@ class FunctionNode extends TreeNode {

int requiredParameterCount,

this.returnType: const DynamicType(),

this.inferredReturnValue,

- this.asyncMarker: AsyncMarker.Sync})

+ this.asyncMarker: AsyncMarker.Sync,

+ this.originalAsyncMarker: AsyncMarker.Sync})

: this.positionalParameters =

positionalParameters ?? <VariableDeclaration>[],

this.requiredParameterCount =

« no previous file with comments | « pkg/kernel/binary.md ('k') | pkg/kernel/lib/binary/ast_from_binary.dart » ('j') | pkg/kernel/lib/transformations/continuation.dart » ('J')

Powered by Google App Engine

This is Rietveld 408576698