runtime/observatory/tests/service/causal_async_stack_contents_test.dart - Issue 2690683002: Improvements to causal async stack traces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/causal_async_stack_contents_test.dart

Issue 2690683002: Improvements to causal async stack traces (Closed)

Patch Set: asiva review and rmacnak added on test cases Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/lib/src/service/object.dart ('k') | runtime/observatory/tests/service/causal_async_star_stack_contents_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/service/causal_async_stack_contents_test.dart

diff --git a/runtime/observatory/tests/service/causal_async_stack_contents_test.dart b/runtime/observatory/tests/service/causal_async_stack_contents_test.dart

index 2b015a0ba3e397c4143b6c5e0ca4fa8d2a80d584..9777993ca9d9bbf0a3271733a2e9e11de55d9391 100644

--- a/runtime/observatory/tests/service/causal_async_stack_contents_test.dart

+++ b/runtime/observatory/tests/service/causal_async_stack_contents_test.dart

@@ -47,10 +47,9 @@ var tests = [

// Has causal frames (we are inside an async function)

expect(stack['asyncCausalFrames'], isNotNull);

var asyncStack = stack['asyncCausalFrames'];

- expect(asyncStack[0].toString(), contains('helper_async_body'));

+ expect(asyncStack[0].toString(), contains('helper'));

expect(asyncStack[1].kind, equals(M.FrameKind.asyncSuspensionMarker));

- expect(asyncStack[2].toString(), contains('helper'));

- expect(asyncStack[3].toString(), contains('testMain'));

+ expect(asyncStack[2].toString(), contains('testMain'));

resumeIsolate,

@@ -63,9 +62,9 @@ var tests = [

expect(stack['asyncCausalFrames'], isNotNull);

var asyncStack = stack['asyncCausalFrames'];

expect(asyncStack[0].toString(), contains('foobar'));

- expect(asyncStack[1].toString(), contains('helper_async_body'));

+ expect(asyncStack[1].toString(), contains('helper'));

expect(asyncStack[2].kind, equals(M.FrameKind.asyncSuspensionMarker));

- expect(asyncStack[3].toString(), contains('helper'));

+ expect(asyncStack[3].toString(), contains('testMain'));

];